What's the best method of archiving a site?

I'll redirect you you r/DataHoarder [0] (+ r/Archiveteam [1]). It has a good selection on its wiki for general cases [2]

For harder cases, they will to happily help you (that's their hacking's speciality)

[0] https://www.reddit.com/r/DataHoarder/

[1] https://www.reddit.com/r/Archiveteam/

[2] https://www.reddit.com/r/DataHoarder/wiki/software/#wiki_web...

Httrack does a good job if you just want an app.

If you want to code your own, start at the index page and use something like BeautifulSoup to build a table of links. Embed sand recursion rabbitholes will be your main headaches, but it's not that hard to do.

I think there is a old tool called leech. Depends on how big and intricate the website is andof course js usage.