Would Ukraine joining NATO violate promise to have no nuclear weapons?
NATO wouldn't give Ukraine nuclear weapons but it would protect it using them.
No. The nuclear non-proliferation treaty is about countries making their own weapons; it doesn't stop allies using them on a country's behalf. Also, it wouldn't be NATO doing that. It'd be a nuclear nation that's a member of NATO (the US, UK, etc).