HACKER Q&A
📣 tomazio

How to deal with coworker code review who haven't read my code?


I started a new job half a year ago as a senior full stack engineer. There is one coworker who routinely reviews my PRs and leaves feedback that clearly demonstrates they didn't read my code closely or they didn't fully grok it. I then have to go out of way my to prove to this person the code is doing what is expected/asked, either in long winded responses on the PR, or sometimes as far as pulling them into a video call to screen share and live debug the code to them. It's becoming increasingly annoying, and even a little exhausting which is hurting my motivation and delivery throughput. Anyone ever had similar experiences or have any tips to deal with this type of situation?


  👤 MaknMoreGtnLess Accepted Answer ✓
> I then have to go out of way my to prove to this person the code is doing what is expected/asked, either in long winded responses on the PR, or sometimes as far as pulling them into a video call to screen share and live debug the code to them

Process issue. Fix:

1. Write tests

2. Ensure tests can run in a well defined/containerized environment so that they can run tests and ensure they pass


👤 draaglom
I don't have answers but some questions that might help:

* Are their code reviews _of you_ poor in particular, or are they poor in general when reviewing anyone's code?

* Are they reviewing your code in good faith (and are just finding it challenging) or in bad faith (and can't be arsed or don't like you / the project / etc)?

* Have you had a direct conversation with them about it? (Is your relationship with them strong enough to enable that?)

* Do your team have standards for a code review? Expectations for an author and for a reviewer?


👤 bjourne
Your code may be messy or written in a non-obvious way. Does your coworker occasionally suggest how your code could be improved? Do you take those suggestions to heart?

👤 ipaddr
I hate that. I prefer an environment that enforces individual responsibility. I'll push through your code without much review so you need to own your code and make sure everything works.

👤 AnimalMuppet
I would at least consider talking to the co-worker's boss.

Barring that... is there any way you can route your PR reviews to someone else?